Skip to content

Add test to check if processing file with tabs is working#38

Merged
ondrajodas merged 5 commits intomasterfrom
ujovlado-fail-with-tabs
Jun 21, 2022
Merged

Add test to check if processing file with tabs is working#38
ondrajodas merged 5 commits intomasterfrom
ujovlado-fail-with-tabs

Conversation

@ujovlado
Copy link
Member

@ujovlado ujovlado commented Jun 21, 2022 •
edited
Loading

Changes:

  • Add tests to check if processing file without delimiter working
  • Update php-csv to v 3.1 (to address issue with empty delimiter)

@ondrajodas ondrajodas marked this pull request as ready for review June 21, 2022 11:50
@ondrajodas
Copy link
Contributor

ondrajodas commented Jun 21, 2022

updatováno, dám tu @AdamVyborny na review jako nezúčastněnou osobu :)

@ondrajodas ondrajodas requested a review from AdamVyborny June 21, 2022 11:53
AdamVyborny
AdamVyborny approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ondrajodas ondrajodas merged commit dc3adef into master Jun 21, 2022
@ondrajodas ondrajodas deleted the ujovlado-fail-with-tabs branch June 21, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdamVyborny AdamVyborny AdamVyborny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ujovlado @ondrajodas @AdamVyborny