Skip to content

Comments

Add keboola-cli plugin with 10-agent project review#47

Open
ottomansky wants to merge 19 commits intokeboola:mainfrom
ottomansky:feat/add-keboola-cli-plugin
Open

Add keboola-cli plugin with 10-agent project review#47
ottomansky wants to merge 19 commits intokeboola:mainfrom
ottomansky:feat/add-keboola-cli-plugin

Conversation

@ottomansky
Copy link
Collaborator

Summary

  • Adds keboola-cli plugin to plugins/keboola-cli/ with a full project review system
  • 12 agents (7 general reviewers + 3 FI-specific + config-analyzer pre-scan + consolidator)
  • 6 slash commands: /kbc-review, /kbc-fi, /kbc-pull, /kbc-push, /kbc-init, /kbc-diff
  • 2 skills: keboola-config (platform knowledge) and keboola-fi (financial intelligence domain)
  • Shared review standards based on Actum + Keboola best practices
  • Orchestrator with pre-flight validation, scoped review, FI mode (--fi), and consolidation
  • Persistent review output to docs/output/review/<project-name>/

What it does

/kbc-review spawns a team of reviewer agents against a Keboola project via MCP:

Agent Focus
sql-reviewer SQL quality, naming, technical columns, shared codes
config-reviewer Component naming, flow structure, input mappings
dwh-architect L0/L1/L2 architecture, bucket/table naming, lineage
data-quality-analyst PKs, FKs, data types, DQ tests, incremental safety
semantic-layer-reviewer Metrics, dimensions, FI metric depth
security-auditor Encrypted credentials, service accounts, OAuth
performance-optimizer Input mapping efficiency, incremental loading, scheduling
financial-analyst P&L/BS logic, sign conventions, KPIs (--fi only)
template-readiness Parameterization, hardcoded values, reuse score (--fi only)
fi-template-spec ER diagram, source KB, template gaps (--fi only)
config-analyzer Pre-scan, PROJECT_OVERVIEW.md (sonnet)
consolidator Dedup, severity ranking, Mermaid diagram, action items

Validated against Quantilope project (2415): 60 findings, 34 action items, 52% template readiness.

Version history

  • v1.7.1 -- Quality fixes (stale paths, agent counts, step numbering)
  • v1.7.0 -- fi-template-spec agent, FI metric depth, agent trims
  • v1.6.0 -- Persistent review output directory
  • v1.5.0 -- Scope presets, /kbc-fi shorthand, auto-enable --fi
  • v1.4.0 -- FI/general split, --fi flag, FI skill extraction
  • v1.3.0 -- Shared review standards (Actum + Keboola)
  • v1.2.0 -- Pre-flight, scoped review, resilience, Mermaid diagrams
  • v1.1.0 -- Token optimization, prompt compression
  • v1.0.0 -- Initial 10-agent review system

Test plan

  • Validated plugin structure (plugin.json, agents, commands, skills)
  • Ran full /kbc-review --fi against Quantilope project 2415
  • All 10 agents produced reports (13-31KB each)
  • Consolidator produced deduplicated report (24.6KB, 60 findings)
  • Output persisted to docs/output/review/quantilope/
  • Review agent prompt quality and completeness
  • Verify MCP tool usage patterns are correct
  • Test with a non-FI project (general review without --fi)

Generated with Claude Code

ottomansky and others added 15 commits February 6, 2026 15:42
…ency

Delete general knowledge (ERP structures, SaaS metrics, SQL examples),
compress prose checklists to rule tables, apply compact temp-dir output
format. financial-analyst 294->120, template-readiness 331->142,
performance-optimizer 301->119, security-auditor 282->107.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mmand, bump to v1.1.0

Compress checklists to rule tables, delete SQL/code examples, apply
compact temp-dir output format to all agents and kbc-review command.
data-quality 210->120, semantic-layer 206->117, consolidator 200->153,
dwh-architect 165->114, sql-reviewer 159->99, config-reviewer 159->107.
Total: 2377->1268 lines (47% reduction).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…diagrams, action dependencies

- Pre-flight: 5 checks before spawning agents (stale cleanup, .keboola exists, manifest readable, MCP reachable, configs non-empty)
- Dedup: formal definitions for same/related issues, merge procedure, cross-reference enrichment, 30% sanity check
- Mermaid: graph LR data flow diagram with color-coded issue nodes replaces text-only overview
- Action items: dependency-ordered tables with Requires column and common patterns

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…date-only) and orchestration resilience

Scope selection: --scope=sql,security runs only specified agents, --quick skips consolidator for inline summary,
--consolidate-only retries failed consolidation from preserved temp reports.
Auto-quick when 1-2 agents selected.

Orchestration: 5-min per-agent timeout with monitoring loop, 8-min consolidator timeout,
automatic report backup before overwrite, graceful degradation with partial results,
--consolidate-only recovery path for failed runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… config-analyzer pre-scan

Shared context: orchestrator creates SHARED_CONTEXT.md in temp dir, all 9 reviewers
read and append cross-domain findings (append-only to avoid contention), consolidator
reads shared context to enrich merged findings.

Pre-scan: config-analyzer runs on sonnet before review team (90s timeout), writes
PROJECT_OVERVIEW.md with component inventory, data flow summary, bucket structure.
All reviewers read it for shared project context, reducing redundant MCP calls.

Updated: kbc-review.md, all 9 reviewer agents, kbc-review-consolidator.md, keboola-config-analyzer.md
Agent total: 1356 lines (under 1400 target)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
v1.2.0 includes: pre-flight validation, targeted review mode (--scope, --quick,
--consolidate-only), orchestration resilience (timeouts, monitoring, graceful degradation),
structured deduplication rules, Mermaid data flow diagrams, action item dependency ordering,
agent cross-reference via shared context file, config-analyzer pre-scan.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…to review agents (v1.3.0)

- Add shared standards/review-standards.md (142 lines, 10 sections: architecture, bucket/table/column naming, PKs, technical columns, data types, transformation template, platform best practices)
- Update kbc-review.md orchestrator to copy standards file to temp dir and reference in agent prompts
- Update kbc-dwh-architect.md with Actum L0/L1/L2 bucket naming, table suffixes, column suffixes, technical columns checklist
- Update kbc-sql-reviewer.md with 6 new rules (technical columns, UPPERCASE, domain suffixes, FK pattern, upsert template, moustache variables)
- Update kbc-config-reviewer.md with 6 new rules (component/flow naming conventions, read-only mappings, flow phases, incremental PKs)
- Update all 6 remaining agents with REVIEW_STANDARDS.md reference in Team Behavior
- Bump plugin version 1.2.0 -> 1.3.0

Agent total: 1389 lines (budget: <1400). Standards file: 142 lines (shared, not counted in agent budget).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
….4.0)

Default /kbc-review runs 7 general agents. --fi flag adds 2 FI agents
(financial-analyst, template-readiness). FI domain knowledge moved to
skills/keboola-fi/. Consolidator uses glob for dynamic report discovery.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…, polish

- Fix data-quality agent step numbering (duplicate 3 -> 3,4,5,6)
- Generalize template-readiness value inventory (domain-agnostic)
- Auto-enable --fi when --scope includes financial/template
- Add /kbc-fi shorthand command
- Add scope presets (quick-check, architecture, compliance)
- Trim consolidator to 178 lines (Mermaid + dedup compression)
- Enrich keboola-fi skill (COA patterns + FI naming conventions)
- Expand README (workflow, flags, presets, version history)
- Bump to v1.5.0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…t output dir

Replace docs/.review_temp/ with docs/output/review/<project-name>/ so agent
reports survive consolidation. Project name sanitized from MCP project info.
Consolidator now deletes only working files (SHARED_CONTEXT.md, REVIEW_STANDARDS.md)
and preserves agent reports + PROJECT_OVERVIEW.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ic depth, agent trims

New fi-template-spec agent (FI-only): template delta, Mermaid ER diagram,
source knowledge base, template gaps. Semantic-reviewer gains FI metric
depth section. Trims to consolidator, template-readiness, financial-analyst,
data-quality-analyst for line budget. kbc-review updated for 10-agent --fi.
SKILL.md adds template specification patterns. Plugin bumped to v1.7.0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tep numbering, fork bomb

- Replace docs/.review_temp/ with <review_output_dir>/ in 10 agent files + config-analyzer
- Fix FI agent count from 2 to 3 in SKILL.md, README.md, all references
- Add kbc-fi-template-spec to agent lists in SKILL.md, README.md
- Fix duplicate step 3 in Team Behavior (semantic, security, performance, financial)
- Remove impossible "Message consolidator" step from all 11 reviewer agents
- Remove fork bomb from plugin.json author name
- Change config-analyzer model from sonnet to inherit
- Improve description trigger phrases in SKILL.md, keboola-fi/SKILL.md, kbc-fi.md
- Fix stale output path docs/PROJECT_REVIEW_REPORT.md -> docs/output/review/<project-name>/
- Add v1.6.0, v1.7.0, v1.7.1 to README version history
- Bump plugin version to 1.7.1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…E wording

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…andards ref

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jordanrburger jordanrburger self-requested a review February 9, 2026 14:44
ottomansky and others added 4 commits February 10, 2026 10:30
…, naming conventions report

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- PK on every L1+ table (HIGH)
- Composite PK uniqueness, no NULL components (CRITICAL)
- FK explicit references to table.PK (MEDIUM)
- FK cardinality documented (MEDIUM)
- No orphan FKs in L2 mart tables (HIGH)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…K checks

dwh-architect: PK/FK Integrity checklist (5 items) + PK/FK Validation output table
data-quality: 3 new checks (cross-layer FK, PK uniqueness, composite PK NULLs)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- SKILL.md: Core Template Scope section (14 core tables, root variables, core vs addon metrics)
- plugin.json: bump to 1.9.0
- README: add v1.9.0 to version history

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants