Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging system initialized correctly #287

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

Shivani-Bajaj
Copy link
Contributor

There is a warning that appears while running the app stating Logging Error: Failed to initialize logging system. Log messages may be missing.?

So to solve this warning, an environmental variable is added to the current scheme IDEPreferLogStreaming=YES
warning fix

@kean
Copy link
Owner

kean commented Sep 3, 2024

Hey, thanks for the PR 👋
I wonder what is the root cause of the error. It's not something that I saw before and after a quick search I couldn't find anything conclusive.
(ignore the CI errors)

@Shivani-Bajaj
Copy link
Contributor Author

Hey, thanks for the PR 👋 I wonder what is the root cause of the error. It's not something that I saw before and after a quick search I couldn't find anything conclusive. (ignore the CI errors)

It think it to be a bug in 15.3 and above Xcode versions. IDEPreferLogStreaming controls whether Xcode or the IDE should prefer log streaming over direct file writes. So I think in these xcode versions, this is not set by default.

Also, regarding the CI error, there was a compilation error occurring and I commented out that line to run the code. There was a lot of commented code around that, which I am not sure is referred by someone or is unused as of now. So I can remove it as well, but need to know your opinion on that.

@kean
Copy link
Owner

kean commented Sep 3, 2024

I am not sure is referred by someone or is unused as of now

It's work-in-progress code for Pulse 5.0. The latest version of the codebase is in the following PR/branch: #285.

@Shivani-Bajaj
Copy link
Contributor Author

I am not sure is referred by someone or is unused as of now

It's work-in-progress code for Pulse 5.0. The latest version of the codebase is in the following PR/branch: #285.

Thanks for clarifying. So I don't need to make any changes around that. Will wait for your approval on PR if things seem fine to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants