test: Enable test for consistent-indexed-object-style rule

[delino]

Summary

• Uncommented the test file for consistent-indexed-object-style rule in rstest.config.mts
• Follow-up to Enable test for consistent-generic-constructors rule #155, which enabled the test for consistent-generic-constructors rule

Context

This PR enables the test suite for consistent-indexed-object-style rule, which enforces consistent usage of indexed object types in TypeScript.

Changes

Test Configuration (rstest.config.mts:40)

• Uncommented the line enabling the consistent-indexed-object-style test file

Implementation Status

The Go implementation at internal/plugins/typescript/rules/consistent_indexed_object_style/ already supports all required features:

1. Default 'record' style: Enforces use of Record<K, V> utility type

   • Example: type Foo = Record<string, any>;

2. 'index-signature' style option: Enforces use of index signatures

   • Example: type Foo = { [key: string]: any };

3. 'mapped-type' style option: Enforces use of mapped types

   • Example: type Foo = { [K in string]: any };

4. Comprehensive coverage:

   • Interface declarations with index signatures
   • Type literals with index signatures
   • Mapped types
   • Record type references
   • Circular reference detection to avoid false positives

TypeScript-ESLint Reference

The implementation follows the behavior of the TypeScript-ESLint consistent-indexed-object-style rule:
https://typescript-eslint.io/rules/consistent-indexed-object-style/

Documentation References

• TypeScript index signatures: https://www.typescriptlang.org/docs/handbook/2/objects.html#index-signatures
• Record utility type: https://www.typescriptlang.org/docs/handbook/utility-types.html#recordkeys-type

🤖 Generated with Claude Code

[kdy1]

🤖 This pull request has been linked to DevBird Task #1538

View the task details and manage the automated development workflow in DevBird.

Learn more about DevBird here or the announcement blog post here.

[kdy1]

📋 DevBird Task Prompt

Enable the test for the consistent-indexed-object-style rule and ensure it passes.

Objective

Uncomment the test file './tests/typescript-eslint/rules/consistent-indexed-object-style.test.ts' in /home/runner/work/rslint/rslint/packages/rslint-test-tools/rstest.config.mts (line 40) and ensure all tests pass.

Documentation & Resources

• TypeScript-ESLint consistent-indexed-object-style: https://typescript-eslint.io/rules/consistent-indexed-object-style/
• TypeScript index signatures: https://www.typescriptlang.org/docs/handbook/2/objects.html#index-signatures
• Record utility type: https://www.typescriptlang.org/docs/handbook/utility-types.html#recordkeys-type

Implementation Steps

1. Uncomment test in rstest.config.mts (line 40)
2. Run tests
3. Examine Go implementation at /home/runner/work/rslint/rslint/internal/plugins/typescript/rules/consistent_indexed_object_style/
4. Fix any issues

Critical Requirement

If CI fails, implement from scratch:

• Reference: https://typescript-eslint.io/rules/consistent-indexed-object-style/
• Enforce consistent style for indexed object types
• Three styles: 'record' (Record<string, number>), 'index-signature' ({ [key: string]: number }), 'mapped-type' ({ [K in string]: number })
• Support options to choose preferred style
• Provide auto-fixes to convert between styles

Success Criteria

• Test uncommented
• All tests pass
• CI succeeds

---

This comment was automatically added by DevBird. You can disable this feature in DevBird Settings.

[claude]

PR Review: Enable test for consistent-indexed-object-style rule

Summary

This PR uncomments the test file for the consistent-indexed-object-style rule in the test configuration, following the same pattern as PR #155. The change is minimal and well-documented.

---

Code Quality: ✅ Excellent

Positive Aspects:

• Minimal, focused change: The PR touches exactly one line, making it easy to review and low-risk
• Follows established pattern: Mirrors the approach used in PR Enable test for consistent-generic-constructors rule #155 for enabling tests incrementally
• Well-documented: The PR description thoroughly explains the implementation status and references
• Comprehensive test coverage: The test file includes 306 valid cases and 655 invalid cases, covering edge cases like:
  • Circular references (direct and indirect)
  • Generic type parameters
  • Readonly modifiers
  • Mapped types with various modifiers
  • All three style options (record, index-signature, mapped-type)

Go Implementation Verification:
The Go implementation at internal/plugins/typescript/rules/consistent_indexed_object_style/consistent_indexed_object_style.go properly handles:

• Interface declarations with index signatures
• Type literals with index signatures
• Mapped types that can be converted to Record
• Record type references (for index-signature style)
• Circular reference detection to avoid false positives

---

Potential Issues: ⚠️ Minor

1. Test Execution Not Verified
The PR description states the implementation "already supports all required features," but doesn't include test execution results.

Recommendation: Before merging, verify that:

pnpm test

passes successfully with this test file enabled. It would be helpful to include test results in the PR description or as a comment.

2. No Build/CI Status Visible
Cannot verify if CI checks are passing from the PR diff alone.

Recommendation: Ensure all CI checks pass before merging.

---

Best Practices: ✅ Good

• Incremental enablement: Enabling tests one at a time is a smart approach for managing technical debt
• Documentation references: Links to TypeScript-ESLint docs and TypeScript handbook are valuable
• Commit message follows conventions: Uses conventional commit format with proper scope and co-authoring

---

Performance Considerations: ✅ No Concerns

• Single line change has no performance impact
• The test suite itself is comprehensive but doesn't affect runtime performance

---

Security Concerns: ✅ None

No security implications from this change.

---

Test Coverage: ✅ Comprehensive

The test file includes extensive coverage:

• Valid cases: Multiple scenarios where the rule should not trigger
• Invalid cases: Comprehensive error cases with expected fixes
• Edge cases: Circular references, generic types, readonly modifiers, mapped types
• All configuration options: Tests for 'record', 'index-signature', and 'mapped-type' styles

---

Recommendations

1. Before merging: Run the test suite and confirm all tests pass
2. Consider: Adding a follow-up comment with test execution results
3. Pattern for future PRs: This incremental approach is working well - continue with remaining commented-out tests

---

Overall Assessment: ✅ APPROVED

This is a well-executed, low-risk change that follows the established pattern for incrementally enabling test coverage. The implementation appears solid based on code review, and the only remaining item is verification that tests actually pass.

Merge recommendation: Approve pending successful test execution.