Skip to content

Commit

Permalink
VFS: use synchronize_rcu_expedited() in namespace_unlock()
Browse files Browse the repository at this point in the history
The synchronize_rcu() in namespace_unlock() is called every time
a filesystem is unmounted.  If a great many filesystems are mounted,
this can cause a noticable slow-down in, for example, system shutdown.

The sequence:
  mkdir -p /tmp/Mtest/{0..5000}
  time for i in /tmp/Mtest/*; do mount -t tmpfs tmpfs $i ; done
  time umount /tmp/Mtest/*

on a 4-cpu VM can report 8 seconds to mount the tmpfs filesystems, and
100 seconds to unmount them.

Boot the same VM with 1 CPU and it takes 18 seconds to mount the
tmpfs filesystems, but only 36 to unmount.

If we change the synchronize_rcu() to synchronize_rcu_expedited()
the umount time on a 4-cpu VM drop to 0.6 seconds

I think this 200-fold speed up is worth the slightly high system
impact of using synchronize_rcu_expedited().

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> (from general rcu perspective)
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Danny Lin <danny@kdrag0n.dev>
  • Loading branch information
NeilBrown authored and kdrag0n committed Aug 12, 2020
1 parent 0f15d5a commit b00faba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/namespace.c
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ static void namespace_unlock(void)
if (likely(hlist_empty(&head)))
return;

synchronize_rcu();
synchronize_rcu_expedited();

group_pin_kill(&head);
}
Expand Down

0 comments on commit b00faba

Please sign in to comment.