Feat/wk/schedule v2 #94

Icarus9913 · 2023-07-19T11:29:00Z

No description provided.

codecov · 2023-07-19T11:31:40Z

Codecov Report

Merging #94 (e1c9c7e) into main (2caa6aa) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   40.63%   40.63%           
=======================================
  Files           8        8           
  Lines         507      507           
=======================================
  Hits          206      206           
  Misses        296      296           
  Partials        5        5

Flag	Coverage Δ
unittests	`40.63% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

cmd/agent/cmd/cert.go

cmd/agent/cmd/config.go

pkg/k8s/apis/kdoctor.io/v1beta1/common_types.go

weizhoublue · 2023-08-02T13:10:56Z

pkg/k8s/apis/kdoctor.io/v1beta1/common_types.go

+	RuntimeStatus string `json:"runtimeStatus,omitempty"`
+}
+
+const (


type RuntimeStatus 给个 enum 把

pkg/pluginManager/agentManager.go

weizhoublue · 2023-08-02T13:22:13Z

pkg/pluginManager/controllerReconciler.go

+
+			if instance.Status.Resource == nil {
+				newScheduler := scheduler.NewScheduler(s.client, s.apiReader, KindNameNetReach, instance.Name, s.runtimeUniqueMatchLabelKey, logger)
+				resource, err = newScheduler.CreateTaskRuntimeIfNotExist(ctx, &instance, instance.Spec.AgentSpec)


// comment: creat the resource and update to creating status

weizhoublue · 2023-08-02T13:24:38Z

pkg/pluginManager/controllerReconciler.go

 		if instance.DeletionTimestamp != nil {
 			s.logger.Sugar().Debugf("ignore deleting task %v", req)
 			return ctrl.Result{}, nil
 		}

+		// create resource


有好几个 kind 都复用这段类似的代码，是否可抽象出函数

pkg/pluginManager/controllerReconciler.go

weizhoublue · 2023-08-02T13:36:42Z

pkg/pluginManager/controllerTools.go


-							newRecord := NewStatusHistoryRecord(startTime, int(n+1), schedulePlan)
+				// add new round record


这个函数中的这些新增代码，是因为原来的有 bug 么？

weizhoublue · 2023-08-03T02:39:05Z

pkg/pluginManager/controllerReconciler.go

+				}
+			}
+
+			// let the tracker trace status


// comment:
// trace, will do things:
// the tracer will be asynchronous to update the resource status in the CR
//

weizhoublue · 2023-08-03T02:48:35Z

pkg/scheduler/cachedb.go

@@ -0,0 +1,126 @@
+// Copyright 2023 Authors of kdoctor-io
+// SPDX-License-Identifier: Apache-2.0


readme.md
(1) created
(2)delete,

weizhoublue · 2023-08-03T04:09:36Z

add corresponding E2E in test/docs

Signed-off-by: Icarus9913 <icaruswu66@qq.com>

Icarus9913 requested a review from weizhoublue as a code owner July 19, 2023 11:29

Icarus9913 force-pushed the feat/wk/schedule-v2 branch 11 times, most recently from 0ed7781 to 3f20485 Compare July 27, 2023 10:00

Icarus9913 force-pushed the feat/wk/schedule-v2 branch 17 times, most recently from 21403ef to 26d4a10 Compare August 2, 2023 07:21