btrfs-convert copy inodes UI appears to be incomplete

[cmurf]

btrfs-progs-5.10-2.fc34.x86_64

The 'copy inodes' portion of the convert shows status with what looks like '$converted inodes / $total inodes' UI to indicate how far along it it. But so far it never shows the same converted value as total value, leaving it visually ambiguous if it's actually complete with some kind of silent failure?

copy inodes [o] [ 0/ 2379]
copy inodes [o] [ 0/ 2136]
copy inodes [o] [ 0/ 11]
copy inodes [o] [ 152026/ 153058]

It looks like it's just not doing a final update of the fs state.

Example, 4 conversions

[root@localhost-live liveuser]# btrfs-convert /dev/vda3
create btrfs filesystem:
	blocksize: 4096
	nodesize:  16384
	features:  extref, skinny-metadata (default)
	checksum:  crc32c
free space report:
	total:     21474836480
	free:      20623712256 (96.04%)
creating ext2 image file
creating btrfs metadata
copy inodes [o] [         0/      2379]
conversion complete
[root@localhost-live liveuser]# btrfs-convert /dev/vda4
create btrfs filesystem:
	blocksize: 4096
	nodesize:  16384
	features:  extref, skinny-metadata (default)
	checksum:  crc32c
free space report:
	total:     21474836480
	free:      20693188608 (96.36%)
creating ext2 image file
creating btrfs metadata
copy inodes [o] [         0/        11]
conversion complete
[root@localhost-live liveuser]# btrfs-convert /dev/vda5
create btrfs filesystem:
	blocksize: 4096
	nodesize:  16384
	features:  extref, skinny-metadata (default)
	checksum:  crc32c
free space report:
	total:     21474836480
	free:      20464263168 (95.29%)
creating ext2 image file
creating btrfs metadata
copy inodes [o] [         0/      2136]
conversion complete
[root@localhost-live liveuser]# btrfs-convert /dev/vda6
create btrfs filesystem:
	blocksize: 4096
	nodesize:  16384
	features:  extref, skinny-metadata (default)
	checksum:  crc32c
free space report:
	total:     32212254720
	free:      25697779712 (79.78%)
creating ext2 image file
creating btrfs metadata
copy inodes [o] [    152026/    153058]
conversion complete
[root@localhost-live liveuser]# 

[realwakka]

the code that prints 'copy inodes' is called from worker thread so it can be incorrect. also even if it's on main thread, the count '$converted inodes / $total inodes' is incorrect again. because $total inodes was calculated with inodes_count - free_inodes_count. and it seems that ext2_copy_inodes() copy all the inodes includes free inodes. it also doesn't count special inodes.

[QuLogic]

For me it said something like ~8M/1M. If it's really converted / total, then it's even more confusing to me being far more than 100%.