Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rewrite tests #54

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

ptt-homme
Copy link
Contributor

This PR has as base branch (#53), I'll rebase it on master as soon as #53 is merged.

@kdabir
Copy link
Owner

kdabir commented Apr 25, 2021

Hey Sorry for the long gap. I have merged #53. Let me know once this is done, will merge it.

Also, reg -V i would much prefer lowercase (-v). Is there any specific reason you chose uppercase V? I could think of using it as inverse of --quiet as -v, --verbose but wanted to confirm.

@ptt-homme
Copy link
Contributor Author

Hey, no problems! Thanks for #53.

I'm also a bit busy at the moment, but i'll try to find spare time to finish this.

For "v" or "V", let me know which is the best for you and i'll update it!

@kdabir
Copy link
Owner

kdabir commented Apr 30, 2021

I would prefer lowercase -v as that is arguably more common (depends on ecosystem oone is coming from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants