Change Git default branch to main in update_rules tool #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
dco-signoff: yes
On-behalf-of: @SAP marko.mudrinic@sap.com Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
force-pushed
the
fix-update-rules
branch
from
50864fe to
2cdc850
Compare
kcp-ci-bot
added
size/XXL
Member
|
What's going on with the massive drop of testdata, can we quickly add a note in the PR description on that? |
|
LGTM label has been added. Git tree hash: 7891843962832bd3ae297bafdbcd07e466f2d7f1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says in the title, this is required to find the proper set of rules to copy when creating rules for a new branch.
The testdata contained rules for
kubernetes/kuberneteswhich are quite large in size and are based on themasterbranch. I changed testdata with our rules which are based on themainbranch. There are less rules, but it's good enough for what are tests covering./assign @xrstf @embik