Skip to content

[release-0.28] Fix object validation #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

[release-0.28] Fix object validation #3599

merged 1 commit into from
Sep 25, 2025

Conversation

SimonTheLeg
Copy link
Contributor

@SimonTheLeg SimonTheLeg commented Sep 25, 2025 •
edited by embik
Loading

Summary

Fixes an issue when validating objects.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

Execute object validation in virtual workspaces

@SimonTheLeg
Fix object validation
2b01646 
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>

On-behalf-of: SAP <simon.bein@sap.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2025
@SimonTheLeg SimonTheLeg requested a review from embik September 25, 2025 11:38
@embik embik changed the title Fix object validation [release-0.28] Fix object validation Sep 25, 2025
embik
embik approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: edfedd1d19a8b2bd1703cbc8d813780a2d1dc248

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@kcp-ci-bot kcp-ci-bot merged commit 02134a2 into kcp-dev:release-0.28 Sep 25, 2025
14 checks passed
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 25, 2025
@GoVulnBot GoVulnBot mentioned this pull request Sep 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonTheLeg @kcp-ci-bot @embik