[release-0.28] fix flakiness in TestAPIExportBindingAuthorizer #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test's intention is to ensure there is 1 consumer per shard for the wildwest API. To achieve this it creates 1 workspace for each shard and then binds to the APIExport from within there. However the code failed to ensure that the logicalclusters for these workspaces are actually at least evenly distributed to every shard. This lead to flakiness as sometimes both logicalclusters were scheduled onto the same shard, and suddenly there was only one consumer shard and so the test faile. On-behalf-of: @SAP christoph.mewes@sap.com
kcp-ci-bot
added
release-note-none
|
/kind flake |
kcp-ci-bot
added
kind/flake
|
LGTM label has been added. Git tree hash: 2a4ee02a5fc81b56129e07695a9b68f1a858d86c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3533
/assign embik