Skip to content

Move to dynamic rest mapper #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Move to dynamic rest mapper #3462

merged 1 commit into from
Jun 24, 2025

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Jun 22, 2025 •
edited by embik
Loading

Summary

This PR uses the new dynamic rest mapper introduced in #3316 in our controllers.

What Type of PR Is This?

Related Issue(s)

Fixes #3413

Release Notes

Move to use dynamicRestMapper everywhere to dynamically resolve Kind to resource and vice versa

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/dynamic.restmapper.usage branch from 77efb72 to 72ca2d1 Compare June 22, 2025 14:13
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae329e40d388f2276314e1982ab358f6e30b2f5b

@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@ntnn
Copy link
Member

ntnn commented Jun 23, 2025

/retest

@mjudeikis
Start using dymanic rest mapper.
ab359fa 
Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT>
On-behalf-of: @SAP mangirdas.judeikis@sap.com
@mjudeikis mjudeikis force-pushed the mjudeikis/dynamic.restmapper.usage branch from 72ca2d1 to ab359fa Compare June 23, 2025 06:09
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 23, 2025
@embik
Copy link
Member

embik commented Jun 23, 2025

Do we think this needs a release note? If yes, the current one is super cryptic, it should explain what this does for end users.

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

Do we think this needs a release note? If yes, the current one is super cryptic, it should explain what this does for end users.

Updated a bit. But as its not user facing feature not sure if we need one at all.

@ntnn
Copy link
Member

ntnn commented Jun 23, 2025

nitpick, but:

vice versa

@embik
Copy link
Member

embik commented Jun 24, 2025

/kind cleanup

@kcp-ci-bot kcp-ci-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 24, 2025
@embik embik removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 24, 2025
embik
embik approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@embik
Copy link
Member

embik commented Jun 24, 2025

#3444

/retest

@kcp-ci-bot kcp-ci-bot merged commit f9221d7 into kcp-dev:main Jun 24, 2025
14 checks passed
@kcp-ci-bot kcp-ci-bot added this to the v0.28.0 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

+1 more reviewer

@ntnn ntnn ntnn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@embik embik

@ntnn ntnn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

feature: replace + "s" hacks with dynamicRest mapper
4 participants
@mjudeikis @kcp-ci-bot @ntnn @embik