Skip to content

CachedResourcesEndpointSlice SDK #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2025
Merged

CachedResourcesEndpointSlice SDK #3442

merged 4 commits into from
Jun 11, 2025

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Jun 4, 2025 •
edited
Loading

Summary

This PR adds types and generated code for CachedResourcesEndpointSlice and friends. First in series for #3417.

What Type of PR Is This?

/kind api-change
/kind feature

Related Issue(s)

Part of #3417

Release Notes

Added CachedResourcesEndpointSlice SDK

gman0 added 4 commits June 4, 2025 17:57
@gman0
sdk: added CachedResourceEndpointSlice types
5920faa 
On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Regenerated code
ac5cdd2 
Ran:

    make codegen

For CachedResourceEndpointSlice and related types.

On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Register CachedResourceEndpointSlice{,List} with sdk/apis/cache/v1alpha1
fcbc38a 
On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Register cachedresourceendpoingslices with system CRDs
d0f9d56 
On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Jun 4, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 4, 2025
@gman0
Copy link
Contributor Author

gman0 commented Jun 4, 2025

Partitions support is to be delivered in next iteration of PRs. Let me know if it's better to have it included here already please.

@gman0
Copy link
Contributor Author

gman0 commented Jun 5, 2025

PTAL @mjudeikis @sttts @xrstf

mjudeikis
mjudeikis reviewed Jun 6, 2025
View reviewed changes
sdk/apis/cache/v1alpha1/types_cachedresourceendpointslice.go
// +required
// +kubebuilder:validation:Required
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="CachedResource reference must not be changed"
CachedResource CachedResourceReference `json:"cachedResource"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for other revieweers, we said we gonna keep it to minimum for now and extend once we need to.

@mjudeikis
Copy link
Contributor

/lgtm
/hold

Once you have follow-up readi we can merge together

@kcp-ci-bot kcp-ci-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 6, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c223d0be3f4beb2b1a9c4d7cc510d2235cbcb707

@embik embik merged commit 7e7205b into kcp-dev:main Jun 11, 2025
13 of 14 checks passed
@kcp-ci-bot kcp-ci-bot added this to the v0.28.0 milestone Jun 11, 2025
@embik
Copy link
Member

embik commented Jun 11, 2025

Uhm. That wasn't my intention ...

@mjudeikis
Copy link
Contributor

all good. no harm done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis mjudeikis left review comments

Assignees

@mjudeikis mjudeikis

Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gman0 @kcp-ci-bot @mjudeikis @embik