✨ auth: Implement user scopes #3235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
mjudeikis
reviewed
Jan 9, 2025
mjudeikis
reviewed
Jan 11, 2025
kcp-ci-bot
added
needs-rebase
sttts
force-pushed
the
sttts-scopes
branch
2 times, most recently
from
d9736ba to
48915f7
Compare
kcp-ci-bot
added
size/XXL
sttts
force-pushed
the
sttts-scopes
branch
2 times, most recently
from
eb92f8f to
f9438f4
Compare
sttts
force-pushed
the
sttts-scopes
branch
4 times, most recently
from
920425b to
9f5086b
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> On-behalf-of: @SAP mangirdas.judeikis@sap.com
Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> On-behalf-of: @SAP mangirdas.judeikis@sap.com Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
|
lgtm (leaving "real" approval for after the PR has been rebased to kcp-dev/kubernetes). |
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: d0572537fdd40869d1c9aa27d7ea12843d4e88ff
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
sttts
commented
Jan 21, 2025
| // service accounts from other workspaces cannot access | ||
| case isServiceAccount && isForeign: | ||
| // Service accounts from other workspaces might conflict with local service accounts by name. | ||
| // Use another reason string to make this very common case clearer. |
There was a problem hiding this comment.
@mjudeikis wondering whether we need all this logic here at all? Isn't the rule resolver doing this work already?
|
/kind feature |
kcp-ci-bot
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vendors kcp-dev/kubernetes#157 for
authentication.kcp.io/scopes: cluster:<name>,...user info extra values that scope down a user to those clusters. In a cluster outside of the users' (potentially existing) scopes, the user is considered authenticated, but it loses it other properties like groups and extra data.This PR uses the mechanism to:
WorkspaceTypeowner cannot use the workspace owner identity for other purposes than accessing the logical cluster at hand.This is towards warrant support in #3156.
Related issue(s)
Release Notes