Add X-Remote-Extra- headers prefix configuration #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
dco-signoff: yes
|
LGTM label has been added. Git tree hash: aea6a08d5ef6e6aa24ed13c74ad8363bbcaf2303
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103.
kcp-front-proxy sets the
X-Remote-headers after validating a ServiceAccount token, but the kcp server wasn't accepting that header. This fixes that oversight, so now all extra auth information parsed by the front-proxy should be accepted by the kcp server.Some of the information lost in the process was the clusterName that the ServiceAccount is coming from, which resulted in having to explicitly grant them access via RBAC if the ServiceAccount token was used against the front-proxy (but not against the server directly).