Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl local source and remote source including git, https. #8

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: kcl-lang/kcl#479

feat: impl local source and remote source including git, oci and https.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/source/**

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the feat label Jun 25, 2023
@Peefy Peefy self-assigned this Jun 25, 2023
@Peefy Peefy requested review from NeverRaR and He1pa June 25, 2023 16:06
@Peefy Peefy changed the title feat: impl local source and remote source including git, oci and https. feat: impl local source and remote source including git, https. Jun 26, 2023
pkg/edit/transformer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5023a44 into main Jun 26, 2023
@Peefy Peefy deleted the feat-local-remote-source branch June 26, 2023 06:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants