Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl positional argument count check for call expressions. #713

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: impl positional argument count check for call expressions.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/arg.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/args/call_expr_err_too_few_args_0/main.k
  • test/grammar/types/args/call_expr_err_too_few_args_1/main.k

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Sep 14, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 14, 2023

Pull Request Test Coverage Report for Build 6182107093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 6181415058: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy force-pushed the enhance-call-arg-ty-check-err-msg branch from 75520fc to e7a85bc Compare September 14, 2023 07:30
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9286e95 into kcl-lang:main Sep 14, 2023
9 of 10 checks passed
@Peefy Peefy deleted the enhance-call-arg-ty-check-err-msg branch September 14, 2023 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants