Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance config attr type checking #707

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 12, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #635

feat: enhance config attribute type inference through the config attribute type map.

config: {str:} = {
    "key" = [
        {
            key = "value"
        }
    ]
    "values" = [
        "foo"
        "bar"
    ]
}
values: [str] = config.values

Before this PR, the type of config.values will be inferred as a [{str:str}]|[str] type. In fact, we can derive more precise types, and this PR solves this problem. The more information is in #635

2. What is the scope of this PR (e.g. component or file name):

The kcl sematic model crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/config/config_ty_0/main.k
  • test/grammar/types/config/config_ty_1/main.k
  • test/grammar/types/config/config_ty_2/main.k
  • test/grammar/types/config/config_ty_3/main.k

@Peefy Peefy added the resolver label Sep 12, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Sep 12, 2023
@Peefy Peefy merged commit 039a57b into kcl-lang:main Sep 12, 2023
9 of 10 checks passed
@Peefy Peefy deleted the enhance-config-str-key-load-attr branch September 12, 2023 06:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant