Skip to content

fix net to_ip4 and to_ip6 #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

fix net to_ip4 and to_ip6 #1937

merged 1 commit into from
May 29, 2025

Conversation

liangyuanpeng
Copy link
Contributor

releated:

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@liangyuanpeng liangyuanpeng force-pushed the ip6_to_ip4 branch 3 times, most recently from f68b3b6 to 6a003b4 Compare May 6, 2025 06:24
@liangyuanpeng liangyuanpeng marked this pull request as draft May 6, 2025 06:35
@liangyuanpeng liangyuanpeng force-pushed the ip6_to_ip4 branch 2 times, most recently from 3c131fe to c8c3cb3 Compare May 27, 2025 05:02
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2025

Pull Request Test Coverage Report for Build 15292125470

Details

  • 61 of 103 (59.22%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/net/mod.rs 61 103 59.22%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.97%
kclvm/runtime/src/net/mod.rs 2 66.47%
kclvm/tools/src/LSP/src/util.rs 11 35.0%
kclvm/tools/src/LSP/src/state.rs 17 71.55%
Totals Coverage Status
Change from base Build 14941299851: -0.05%
Covered Lines: 53930
Relevant Lines: 76345

💛 - Coveralls

@liangyuanpeng liangyuanpeng force-pushed the ip6_to_ip4 branch 6 times, most recently from 2d9d9a2 to 25f17cf Compare May 27, 2025 13:26
@liangyuanpeng liangyuanpeng marked this pull request as ready for review May 27, 2025 13:28
@liangyuanpeng liangyuanpeng changed the title [WIP] fix net ip6 to ip4 fix net ip6 to ip4 May 27, 2025
@liangyuanpeng liangyuanpeng changed the title fix net ip6 to ip4 fix net to_ip4 and to_ip6 May 27, 2025
@liangyuanpeng liangyuanpeng force-pushed the ip6_to_ip4 branch 2 times, most recently from 9b3a12d to 15caca5 Compare May 28, 2025 03:35
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Peefy Peefy merged commit d865066 into kcl-lang:main May 29, 2025
13 checks passed
@liangyuanpeng liangyuanpeng deleted the ip6_to_ip4 branch May 29, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants