Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parse error kind and fix the invalid syntax quick fix code #1365

Merged
merged 1 commit into from
May 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #652

feat: add parse error kind and fix the invalid syntax quick fix code

@Peefy Peefy force-pushed the feat-add-parse-error-enum branch from db3d04d to 344f340 Compare May 27, 2024 11:46
kclvm/error/src/lib.rs Outdated Show resolved Hide resolved
kclvm/error/src/lib.rs Outdated Show resolved Hide resolved
@Peefy Peefy force-pushed the feat-add-parse-error-enum branch from 344f340 to 1e259ef Compare May 27, 2024 12:10
@Peefy Peefy force-pushed the feat-add-parse-error-enum branch from 1e259ef to 17438f5 Compare May 27, 2024 12:50
@Peefy Peefy merged commit 0c819ee into kcl-lang:main May 27, 2024
8 of 10 checks passed
@Peefy Peefy deleted the feat-add-parse-error-enum branch May 27, 2024 13:16
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9255149051

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 61 of 79 (77.22%) changed or added relevant lines in 7 files are covered.
  • 9 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lexer/mod.rs 20 23 86.96%
kclvm/tools/src/LSP/src/quick_fix.rs 0 3 0.0%
kclvm/error/src/lib.rs 7 19 36.84%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/token.rs 1 58.9%
kclvm/sema/src/builtin/option.rs 1 0.0%
kclvm/error/src/lib.rs 1 63.2%
kclvm/sema/src/core/scope.rs 3 65.58%
kclvm/query/src/query.rs 3 68.48%
Totals Coverage Status
Change from base Build 9254570529: -0.02%
Covered Lines: 54219
Relevant Lines: 76164

💛 - Coveralls

@Peefy Peefy mentioned this pull request May 27, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants