Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: updated dsound search paths #71

Closed
wants to merge 1 commit into from

Conversation

snikulov
Copy link
Contributor

Added more hints for Direct Sound search.
It will help on computers where DirectX SDK not installed, but present in Windows SDK.

@kcat
Copy link
Owner

kcat commented Sep 16, 2016

Having the version explicitly in the path doesn't seem like a good idea. Wouldn't that require changing it for every release of the SDK?

@snikulov
Copy link
Contributor Author

@kcat DirectSound is deprecated, do it's little possibility to be changed in future. From vista it should be WASAPI.

@snikulov
Copy link
Contributor Author

@kcat it's just a hint for CMake. It's just a list of well known paths

@kcat
Copy link
Owner

kcat commented Sep 18, 2016

DirectSound is deprecated, but the Windows SDK can still be updated and quickly make that path out of date. Is it always installed into Program Files (x86) too, and never Program Files or somewhere else?

@snikulov
Copy link
Contributor Author

@kcat Then we add another hint. But it'll be unlikely because DS was removed since 7.

@kcat
Copy link
Owner

kcat commented Mar 7, 2017

Pull request #78, with commit d142ba1, includes the WindowsSDK paths when searching for DSound. Does that work for you too?

@snikulov
Copy link
Contributor Author

snikulov commented Mar 7, 2017

@kcat I've moved from Windows development, so I'm unable to verify it.
Let's close this.

@snikulov snikulov closed this Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants