Add a gain argument to altonegen #502
Conversation
Add a gain command-line argument to altonegen.c
examples/altonegen.c
Outdated
| if(gain < 0.0 || gain > 1.0) | ||
| { | ||
| fprintf(stderr, "Invalid gain: %s (min: 0.0, max 1.0)\n", argv[i]); | ||
| tone_freq = 1; |
examples/altonegen.c
Outdated
| @@ -175,6 +181,7 @@ int main(int argc, char *argv[]) | |||
| ALint tone_freq = 1000; | |||
| ALCint dev_rate; | |||
| ALenum state; | |||
| ALfloat gain = 1.0f; | |||
examples/altonegen.c
Outdated
| @@ -144,6 +146,10 @@ static ALuint CreateWave(enum WaveType type, ALuint freq, ALuint srate) | |||
| break; | |||
| } | |||
|
|
|||
| if (gain != 1.0) | |||
| for(i = 0;i < srate;i++) | |||
| data[i] *= gain; | |||
| #include "win_main_utf8.h" | ||
| #ifdef _WIN32 | ||
| # include "win_main_utf8.h" | ||
| #endif |
There was a problem hiding this comment.
Is there a reason this was put behind an ifdef, when the header already checks for Windows?
There was a problem hiding this comment.
I made a mistake compiling the examples, leaving out an include directory path. But for me I prefer having the logic that include or excludes platform specific files where I can see it rather than going to the header to check. So my steps went something like, “compilation on Mac failed, why? Saw the Windows specific include, ifdef’ed it out, compilation succeeded. Link failed with code in alhelpers.c missing. Found alhelpers, added the directory, compiled and linked altonegen. Didn’t go back to undo ifdefs cuz the code feels more readable that way.
I shall revert if if you prefer.
Add a gain command-line argument to altonegen.c.
Fix a spelling error in an error message in opensl.cpp
Fix compilation of some of the examples by guarding the include of win_main_utf8.h