Draft
Conversation
Owner
|
Hey -- thanks for putting together a PR, it's nice to see exactly what you had in mind :) Unfortunately there's a bit of a conflict though, I'm getting ready to roll out a big refactor of the frontend javascript and then implement the popout board on top of that. (see the js_modularize branch). I also have a WIP implementation of the popout board locally which will support players within the room resizing their board. I'm not sure yet if I want to open that up to viewers though, since I'm concerned about the additional load that it might put on the server. |
lepelog
force-pushed
the
feature/popout-board
branch
from
49c046b to
91b7b55
Compare
Owner
|
My current implementation of a popout is at #85 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic popout board that can be viewed by everyone with the link (basically #68 ).
There are a few unresolved questions though, should every board have this option available? Currently a key gets generated when the room is generated, but it could be an option when the room is created.
Where should the link that can be shared be displayed? Currently it's just a link in the room settings on the side of the board titled "Popout URL", which is probably not optimal.
Another question is if only the board should be shown or the players, their score and/or the chat as well. I would implement all of them