Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export quorum queue member metrics #360

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Export quorum queue member metrics #360

merged 4 commits into from
Mar 18, 2024

Conversation

zaeemarshad
Copy link

WHAT

Exposes members_len and online_len metric for quorum queues. The members_len shows the number of Raft members the queue was started with while online_len shows the current number of raft members the queue has. Under normal scenario, these two numbers are same. However, when a node is replaced, the raft membership is actually reduced and has to be manually increased. These two metrics can be used to alert for such a situation where the online nodes length is less than the expected members length.

Proof

# HELP rabbitmq_queue_online_nodes_len Number of online members nodes for the queue
# TYPE rabbitmq_queue_online_nodes_len gauge
rabbitmq_queue_online_nodes_len{cluster="rabbit@rabbit-1",durable="true",policy="",queue="qq-test-2",self="0",vhost="/"} 2

# HELP rabbitmq_queue_member_nodes_len Number of quorum queue member nodes for the queue
# TYPE rabbitmq_queue_member_nodes_len gauge
rabbitmq_queue_member_nodes_len{cluster="rabbit@rabbit-1",durable="true",policy="",queue="qq-test-2",self="0",vhost="/"} 3

@kbudde
Copy link
Owner

kbudde commented Mar 17, 2024

@zaeemarshad I decided to stop accepting new features. Your change looks quite simple.
If you can solve the conflicts, I would put it into a release.

@zaeemarshad
Copy link
Author

@zaeemarshad I decided to stop accepting new features. Your change looks quite simple. If you can solve the conflicts, I would put it into a release.

@kbudde Thanks - I have resolved the conflicts.

@kbudde kbudde merged commit 1859734 into kbudde:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants