Improve Xml- and JsonSerializer #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbsali
approved these changes
Mar 14, 2022
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
JsonSerializerandXmlSerializerintroduced in #310. The serializers have been extended to encode JSON or XML from an array for a request body. The methodsRedmine\Api\AbstractApi::attachCustomFieldXML()andRedmine\Api\Project::prepareParamsXml()that generated XML are thus deprecated.The next step is to replace the
get(),post(),put()anddelete()methods inAbstractApiby using only the serializer andClientclasses in the API classes. This will then be the final preparation to be able to dynamically switch the format in the request/response between XML and JSON, see #146.