Make it possible to build with COMPRESS=0

kbeckmann · Oct 14, 2021 · d483651 · d483651
1 parent 9c48cc2
commit d483651
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Makefile.common b/Makefile.common
@@ -44,7 +44,9 @@ endif
 
 # Compress supported ROMs by default. Set to 0 to disable.
 COMPRESS ?= lzma
-ifdef COMPRESS
+ifeq ($(COMPRESS),0)
+	COMPRESS_PARAM :=
+else
 	COMPRESS_PARAM := --compress=$(COMPRESS)
 endif
 

diff --git a/parse_roms.py b/parse_roms.py
@@ -529,7 +529,7 @@ def contains_rom_by_name(rom, roms):
         roms_compressed = find_compressed_roms()
 
         roms_raw = [r for r in roms_raw if not contains_rom_by_name(r, roms_compressed)]
-        if roms_raw:
+        if roms_raw and compress != None:
             pbar = tqdm(roms_raw) if tqdm else roms_raw
             for r in pbar:
                 if tqdm:
@@ -744,7 +744,7 @@ def parse(self, args):
         "--compress",
         choices=compression_choices,
         type=str,
-        default="",
+        default=None,
         help="Compression method. Defaults to no compression.",
     )
     parser.add_argument(