Support Default Columns (last PR for v1.0.10) #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The column selector and defaults are working well. I think I spotted a small bug where the descending/ascending behavior on the column sorting is flipped. I would expect to see descending values when the arrow points down and ascending values when the arrow points up. |
Fixed in the above commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds default hidden/visible columns, frees Gavin from UI meetings
To compare this and the previous state of things, see the default hidden columns / selected in the dropdown at https://ci-europa.kbase.us/collections/GTDB/genome_attribs vs localhost (fewer visible by default)