Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitpack Java client #479

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add jitpack Java client #479

merged 1 commit into from
Apr 25, 2024

Conversation

MrCreosote
Copy link
Member

No description provided.

@MrCreosote MrCreosote changed the base branch from master to develop April 24, 2024 23:23
@MrCreosote
Copy link
Member Author

MrCreosote commented Apr 24, 2024

So

  • Tests seem to be broken, which must be prior to this commit as it doesn't touch the tests or the service.
    • Also the tests are abstracted away from the workflow file enough that there's no useful debugging info in the output
  • The docker build is coded to fail if the target branch isn't master (why is it running in that case...?)
  • The 2 tasks marked as required don't run at all based on the current GHA workflows

All I want to do it publish a client jar,which has nothing to do with any of this stuff and is completely orthogonal.

You can see the published jars here: https://javadoc.jitpack.io/com/github/kbase/sample_service/24ee07f

Javadoc: https://javadoc.jitpack.io/com/github/kbase/sample_service/24ee07f/javadoc/

... so it's clear the changes here work.

I'm proposing that if you're ok with the changes here we go ahead and merge and deal with the broken build some other day.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tianhao-Gu
Copy link
Collaborator

not sure why tests are broken now. But this PR certainly shouldn't affect tests. so 👍

@MrCreosote MrCreosote merged commit b81ff3e into develop Apr 25, 2024
0 of 2 checks passed
@MrCreosote MrCreosote deleted the dev-java_clients branch April 25, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants