Refactor make_interp_spline to use a single solve
#30
+315
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow it will be easier since no conflict with ndarray.ndim
…arest-neighbor vs left zoh vs right zoh
Collaborator
Author
|
@ixjlyons I want to wait to get automated testing and benchmarking before continuing to work on this. It may be out of scope for the first submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored
make_interp_splineto use a single solve call per dimension (the first suggestion of #28.)It seems like there is a difference between this and the latest commit of #27. It's pretty small and is only apparent in the extrapolation (especially in the 2d interpolation example). I'm not sure where it is coming from or if it matters.