Skip to content

Conversation

@kayjan
Copy link
Owner

@kayjan kayjan commented Oct 18, 2025

Description

The following checks will be removed when ASSERTIONS=false (default usage is not changed)

  • Raise error for empty node name
  • Raise error for duplicated path (same child name under the same parent node)

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 18, 2025
@kayjan kayjan enabled auto-merge (squash) October 18, 2025 11:24
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.tree.construct 100% 100% 0
bigtree.tree.export 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (3251 / 3251) 100% (1115 / 1116) 0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 688a43d Previous: 07a7f75 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 18551.80870997438 iter/sec (stddev: 0.000005173758902623608) 19652.13751341503 iter/sec (stddev: 0.000006059834396773584) 1.06
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 407.39812174784424 iter/sec (stddev: 0.00009026317057478269) 408.44228973926033 iter/sec (stddev: 0.0000747082356024446) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 14.437254577770478 iter/sec (stddev: 0.00031435775460613097) 14.412968017239987 iter/sec (stddev: 0.0004909369549811161) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 89.51239082879131 iter/sec (stddev: 0.0002368201019309742) 91.56767895345533 iter/sec (stddev: 0.00027867134814890524) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 27031.9219924032 iter/sec (stddev: 0.0000044114977826922815) 28130.66129474537 iter/sec (stddev: 0.0000035237959360282114) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1871.4204989177076 iter/sec (stddev: 0.000022024042778785036) 1922.8624499547507 iter/sec (stddev: 0.000018240667955317127) 1.03
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 101.98439918134474 iter/sec (stddev: 0.0055974193789482315) 112.5063220115105 iter/sec (stddev: 0.00461836823926094) 1.10
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 130.03496185012995 iter/sec (stddev: 0.00014670400957884794) 131.82444350919997 iter/sec (stddev: 0.00019229889122942195) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan merged commit 32fe3b4 into master Oct 18, 2025
5 checks passed
@kayjan kayjan deleted the feature/optional-checks branch October 18, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants