Add ruff as linter + Remove support for Python 3.8 and 3.9 #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 24c22ed | Previous: f465398 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
18180.578596971085 iter/sec (stddev: 0.000004063530538783718) |
17400.034625837234 iter/sec (stddev: 0.00000501077078486693) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
388.27783018227126 iter/sec (stddev: 0.00011160252185319712) |
466.58591619869424 iter/sec (stddev: 0.000005362839249952752) |
1.20 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
14.08005836848764 iter/sec (stddev: 0.0006607971560050716) |
14.544712934342092 iter/sec (stddev: 0.0003203225538516868) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
87.06314418645856 iter/sec (stddev: 0.000270488496347464) |
84.7375496325377 iter/sec (stddev: 0.0002715021339185096) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
25570.804278324144 iter/sec (stddev: 0.0000017554632950192538) |
25165.494581512117 iter/sec (stddev: 0.000001957342281422594) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1801.727947186992 iter/sec (stddev: 0.000022083156908573593) |
1853.1399557184222 iter/sec (stddev: 0.00002810643389253734) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
94.35935398358937 iter/sec (stddev: 0.006392409987096717) |
102.29167884040143 iter/sec (stddev: 0.005628276882482672) |
1.08 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
124.94061572535087 iter/sec (stddev: 0.00018982748231523487) |
125.02220159885898 iter/sec (stddev: 0.00012496917346182428) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
kayjan
changed the title
kayjan
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)