Fix reingold tilford edge case #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: f738afa | Previous: 4d352c8 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14704.530833662226 iter/sec (stddev: 0.00001506328362764775) |
15889.283472738016 iter/sec (stddev: 0.0000021309369932333623) |
1.08 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
606.486469832912 iter/sec (stddev: 0.00031036811672329877) |
660.7527314940755 iter/sec (stddev: 0.000014264960067433391) |
1.09 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.374592163997837 iter/sec (stddev: 0.0037379402521983997) |
11.64084108820567 iter/sec (stddev: 0.003515461548573417) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
55.88122106704793 iter/sec (stddev: 0.007191952665856574) |
61.71824126811693 iter/sec (stddev: 0.0052538970051561615) |
1.10 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21504.752013009827 iter/sec (stddev: 6.526595703299434e-8) |
20135.207921338 iter/sec (stddev: 0.000003598112856589841) |
0.94 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1630.2218348772951 iter/sec (stddev: 0.000052423128989498556) |
1584.9381426467176 iter/sec (stddev: 0.00005267881880464399) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
160.35788287443307 iter/sec (stddev: 0.000010418794156600911) |
144.48146958689574 iter/sec (stddev: 0.00013843015313241396) |
0.90 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
73.76205783749353 iter/sec (stddev: 0.007142890203263477) |
79.11169965995956 iter/sec (stddev: 0.005944929834990593) |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)