Split export and construct module #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d78ab63 | Previous: f4ad581 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14576.398915229434 iter/sec (stddev: 0.000017064678659907702) |
14724.374435039568 iter/sec (stddev: 0.000018123571066683466) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
303.80957458912326 iter/sec (stddev: 0.0025616965473874605) |
300.0997336450138 iter/sec (stddev: 0.0026200933144663024) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.663511989924794 iter/sec (stddev: 0.0012098448533662187) |
11.663331164865506 iter/sec (stddev: 0.00004113020943152467) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
67.76264270918483 iter/sec (stddev: 0.0031210463662882095) |
64.95689994390095 iter/sec (stddev: 0.004139073938857091) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22192.656671892168 iter/sec (stddev: 0.000002276954546837418) |
22785.53118767537 iter/sec (stddev: 0.00000820215581942095) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1793.1563649390387 iter/sec (stddev: 0.000007481684718488563) |
1751.064778719629 iter/sec (stddev: 0.000002165585226871055) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
126.33397066085489 iter/sec (stddev: 0.00270172865093331) |
113.67073224060093 iter/sec (stddev: 0.00398330927511886) |
0.90 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
98.78146884338562 iter/sec (stddev: 0.002424423291662267) |
91.18576052647406 iter/sec (stddev: 0.0035621585268544066) |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will be backwards compatible, behaves like a regular module but under-the-hood it is a separated into multiple files
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)