Make Node name mandatory #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 03764ce | Previous: c8f58a8 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14805.240759048142 iter/sec (stddev: 0.000017249516373232947) |
14825.049589833483 iter/sec (stddev: 0.000016917388317509215) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
658.4637881796481 iter/sec (stddev: 0.000010359397186085937) |
668.9375983231032 iter/sec (stddev: 0.000021522279807543216) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.479222270201825 iter/sec (stddev: 0.003596530492513591) |
11.411891065187218 iter/sec (stddev: 0.0027941710538901933) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
69.00831691340822 iter/sec (stddev: 0.003055394047239621) |
66.38769803557848 iter/sec (stddev: 0.003954306724801483) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
23110.566729279173 iter/sec (stddev: 0.000003011497070613911) |
22044.640396522336 iter/sec (stddev: 6.099503101784988e-7) |
0.95 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1650.189251952085 iter/sec (stddev: 0.000046738626866054086) |
1706.270484312251 iter/sec (stddev: 0.000022664964368039653) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
124.05846679527548 iter/sec (stddev: 0.003006081693109977) |
115.13397668817075 iter/sec (stddev: 0.0036453953894672294) |
0.93 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
94.87441855086162 iter/sec (stddev: 0.002754970963127508) |
91.22370945807143 iter/sec (stddev: 0.00358193658636543) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node name is already mandatory, but function signature causes confusion. Fixing this
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)