v0.23.0 + Modify module logic changes #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayjan
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 6f9bda2 | Previous: cfc1f6f | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15430.979543185145 iter/sec (stddev: 0.000014827463515953735) |
14989.885574771877 iter/sec (stddev: 0.00001708589186409362) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
675.716287137975 iter/sec (stddev: 0.000034770208197129974) |
558.93442282316 iter/sec (stddev: 0.00032402227795837505) |
0.83 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.05973711426476 iter/sec (stddev: 0.0024794791913281848) |
11.73268022727456 iter/sec (stddev: 0.004286042547794756) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
67.30305247408238 iter/sec (stddev: 0.0035930474259295146) |
69.20622340700955 iter/sec (stddev: 0.0031646574598610533) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22638.365691913288 iter/sec (stddev: 0.000006681169132346653) |
22712.922290046936 iter/sec (stddev: 0.000008758366013802232) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1716.6038160841308 iter/sec (stddev: 0.000010481868081677062) |
1705.2762526226054 iter/sec (stddev: 0.000007878513045773557) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
120.45850506247905 iter/sec (stddev: 0.0032322575045370372) |
120.23956820143515 iter/sec (stddev: 0.003162600839788381) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
91.47279366317149 iter/sec (stddev: 0.0033639807498511546) |
94.29235192847011 iter/sec (stddev: 0.003053433169424502) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
kayjan
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change modify module logic, tests are all backwards compatible except 1 which was corrected. This affects cases when
merge_childrenandoverridingare both set to True.Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)