Check for moved indicator via dataframe operations #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 6d777ab | Previous: 813ebca | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15191.138705021905 iter/sec (stddev: 0.000016962855283030808) |
15748.41590613816 iter/sec (stddev: 0.0000023661914224702133) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
674.6017370589949 iter/sec (stddev: 0.00001002083446038202) |
661.7075873807601 iter/sec (stddev: 0.00002474682815312983) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.756396392227677 iter/sec (stddev: 0.003482761395480418) |
11.866728425630798 iter/sec (stddev: 0.0022199205152099175) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
64.15192798307055 iter/sec (stddev: 0.0041193040817864126) |
66.62856845123079 iter/sec (stddev: 0.003355570704635937) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21181.14539140804 iter/sec (stddev: 0.000006065703389320973) |
22797.790438406555 iter/sec (stddev: 0.000007893291575959746) |
1.08 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1644.8741403972358 iter/sec (stddev: 0.000004670793840459255) |
1632.797280541927 iter/sec (stddev: 0.000013496264287570397) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
105.70802175893682 iter/sec (stddev: 0.0037496437179568446) |
119.07202172444732 iter/sec (stddev: 0.002987010952514173) |
1.13 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
90.5157194667153 iter/sec (stddev: 0.0035836709071692084) |
86.31078348458826 iter/sec (stddev: 0.0014550990421459634) |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for move indicator using dataframe operations instead of list/dict parsing
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)