Skip to content

Conversation

@kayjan
Copy link
Owner

@kayjan kayjan commented Nov 3, 2024

Description

If alias node attribute is present, alias name will appear instead of node_name, otherwise node_name will be used

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the enhancement New feature or request label Nov 3, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 616c05c Previous: 4aa928b Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 14940.659435854146 iter/sec (stddev: 0.000019026617137044373) 15672.065170504808 iter/sec (stddev: 0.000006574961693566089) 1.05
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 667.8960629499554 iter/sec (stddev: 0.000025817670661728237) 672.843436699645 iter/sec (stddev: 0.0000021182797850735144) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.335392361138167 iter/sec (stddev: 0.003068486341424596) 11.994018686029804 iter/sec (stddev: 0.0015248283267637953) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 68.51380008729548 iter/sec (stddev: 0.0032830144778190884) 67.63383433016678 iter/sec (stddev: 0.003513465881109831) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22138.83261923753 iter/sec (stddev: 8.70731291555171e-7) 10587.965612462962 iter/sec (stddev: 0.00007160736022528391) 0.48
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1513.0728739760295 iter/sec (stddev: 0.00008236888904070623) 1669.1872785537014 iter/sec (stddev: 0.000010133335147272483) 1.10
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 115.23964833929448 iter/sec (stddev: 0.0034076738678093647) 116.38900120913748 iter/sec (stddev: 0.0033580300927343524) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 91.71794605565975 iter/sec (stddev: 0.003451908700272496) 94.96261953169208 iter/sec (stddev: 0.0031415301890799093) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2380 / 2380) 100% (1006 / 1006) 0

@kayjan kayjan merged commit 502290d into master Nov 3, 2024
6 checks passed
@kayjan kayjan deleted the feature/print-alias branch November 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants