Add docstring comment to prefer node_name over name #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayjan
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: ebfda72 | Previous: 63961b2 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15798.874014635488 iter/sec (stddev: 0.000015972481526257916) |
16096.709027711444 iter/sec (stddev: 0.0000037561512209419424) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
700.9019416456063 iter/sec (stddev: 0.000019526612339931073) |
687.11611252235 iter/sec (stddev: 0.000004356909141702008) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.29620749855078 iter/sec (stddev: 0.0023283269851229163) |
12.136155295675252 iter/sec (stddev: 0.0028796379898676306) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
66.72213633712026 iter/sec (stddev: 0.003932865832983906) |
71.65650591146239 iter/sec (stddev: 0.002537886918562786) |
1.07 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21606.088595506684 iter/sec (stddev: 0.00000393257436413092) |
11350.370617744285 iter/sec (stddev: 0.00006490625068357492) |
0.53 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1586.4612664674403 iter/sec (stddev: 0.0000605938185583214) |
1775.5115936875593 iter/sec (stddev: 0.00000603734840781264) |
1.12 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
108.30714971887613 iter/sec (stddev: 0.004316849705326227) |
127.47284735931528 iter/sec (stddev: 0.002290996979665179) |
1.18 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
91.07439051389136 iter/sec (stddev: 0.0036758761465116477) |
99.44272396930072 iter/sec (stddev: 0.002352970222132825) |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)