Use node name instead of name #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d0c5329 | Previous: 4bce14e | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15443.908111627483 iter/sec (stddev: 0.000014437635548140214) |
15884.32399861081 iter/sec (stddev: 0.000016443414642303834) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
701.0777352544383 iter/sec (stddev: 0.000004467995619937381) |
707.7512993071506 iter/sec (stddev: 0.000007101331981824486) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.390650165807212 iter/sec (stddev: 0.0021542713074304202) |
12.455330420946554 iter/sec (stddev: 0.0030326749184921772) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
69.20999534490011 iter/sec (stddev: 0.0030367001238457815) |
69.55262582585169 iter/sec (stddev: 0.003217899701346326) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22308.033792052072 iter/sec (stddev: 0.0000023837983810200542) |
22300.8948230986 iter/sec (stddev: 0.0000020098096023962205) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1645.5306482571698 iter/sec (stddev: 0.0000627537469324846) |
1654.518091822389 iter/sec (stddev: 0.00006820341889531787) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
115.89457737847519 iter/sec (stddev: 0.003381915947669812) |
112.22458662592621 iter/sec (stddev: 0.003553869538322106) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
94.08681492027179 iter/sec (stddev: 0.0029388043719695005) |
96.03862104789009 iter/sec (stddev: 0.0030173585613489664) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Side effect: tree_to_dot is able to modify the nodes using
node_attr/edge_attr(Callable) before node name is retrieved.Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)