Fix node docstring and add additional information #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: fff2aa3 | Previous: 384a07e | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15298.21576921385 iter/sec (stddev: 0.000020008010638209235) |
12024.281834680844 iter/sec (stddev: 0.00004066945865196257) |
0.79 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
706.6417683802499 iter/sec (stddev: 0.00003483957537232593) |
713.1499211578733 iter/sec (stddev: 0.00002847222022880613) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.256250321048622 iter/sec (stddev: 0.0038222785043383048) |
12.406327274301638 iter/sec (stddev: 0.0031283895287921295) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
67.0927120977536 iter/sec (stddev: 0.003998124859241916) |
70.3489375894473 iter/sec (stddev: 0.0034139032664167496) |
1.05 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22071.25483879563 iter/sec (stddev: 0.0000031773136097002063) |
23344.495893724637 iter/sec (stddev: 0.000002041770830545473) |
1.06 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1588.4785742849506 iter/sec (stddev: 0.00009828331710421792) |
1695.7903107740099 iter/sec (stddev: 0.000045253066229889915) |
1.07 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
110.1607803749959 iter/sec (stddev: 0.003881674625425511) |
101.99168339414823 iter/sec (stddev: 0.0048215511301963505) |
0.93 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
89.88116173450466 iter/sec (stddev: 0.003907271395932626) |
96.55530733870081 iter/sec (stddev: 0.0029105622442837215) |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node name should not coincide with sep symbol - added docstring information.
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)