Skip to content

fix: polars error handling and python 3.7 support #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayjan merged 1 commit into from
May 30, 2024
Merged

fix: polars error handling and python 3.7 support #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed:
- Misc: Remove support of Python 3.7 due to incompatibility with polars.
### Fixed:
- Tree Constructor and Exporter: Error handling when user only partially download optional dependencies of pandas/polars.

## [0.18.0] - 2024-05-28
### Added:
Expand Down
4 changes: 2 additions & 2 deletions bigtree/utils/assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def assert_dataframe_no_duplicate_attribute(
id_col (str): column of data that is unique, can be name or path
attribute_cols (List[str]): columns of data containing node attribute information,
"""
if isinstance(data, pd.DataFrame):
if pd and isinstance(data, pd.DataFrame):
data_check = data[[id_col] + attribute_cols].astype(str).drop_duplicates()
duplicate_check = (
data_check[id_col]
Expand Down Expand Up @@ -175,7 +175,7 @@ def assert_dataframe_no_duplicate_children(
parent_col (str): column of data containing parent name information
"""
# Filter for child nodes that are parent of other nodes
if isinstance(data, pd.DataFrame):
if pd and isinstance(data, pd.DataFrame):
data_check = data[[child_col, parent_col]].drop_duplicates()
data_check = data_check[data_check[child_col].isin(data_check[parent_col])]
duplicate_check = (
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build-backend = "hatchling.build"
name = "bigtree"
description = "Tree Implementation and Methods for Python, integrated with list, dictionary, pandas and polars DataFrame."
readme = "README.md"
requires-python = ">=3.7"
requires-python = ">=3.8"
license = {text = "MIT"}
keywords = [
"tree",
Expand All @@ -18,7 +18,6 @@ authors = [
classifiers = [
"Development Status :: 4 - Beta",
"Programming Language :: Python",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down