Fix OracleQuery Dialect Quote Char #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noambloom
force-pushed
the
bugfix_oracle_query_quote_char
branch
2 times, most recently
from
76a7601 to
ee7e825
Compare
gl3nn
reviewed
Nov 4, 2020
Oracle SQL query breaks when double quoted
A quoted identifier begins and ends with double quotation marks (").
If you name a schema object using a quoted identifier,
then you must use the double quotation marks whenever you refer to that object.
Thus it makes sense that the user will double quote the identifier
him/herself.
A nonquoted identifier is not surrounded by any punctuation.
See https://docs.oracle.com/database/121/SQLRF/sql_elements008.htm
noambloom
force-pushed
the
bugfix_oracle_query_quote_char
branch
from
ee7e825 to
a59ab3e
Compare
gl3nn
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle SQL query breaks when double quoted
A quoted identifier begins and ends with double quotation marks (").
If you name a schema object using a quoted identifier,
then you must use the double quotation marks whenever you refer to that object.
Thus it makes sense that the user will double quote the identifier
him/herself.
A nonquoted identifier is not surrounded by any punctuation.
See https://docs.oracle.com/database/121/SQLRF/sql_elements008.htm
Addresses #394 (comment)
Addresses #298 for OracleQuery