Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verify SecretsManager JSON Key #533

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix: verify SecretsManager JSON Key #533

merged 2 commits into from
Mar 16, 2023

Conversation

m22r
Copy link
Contributor

@m22r m22r commented Mar 14, 2023

Fixed ecspresso verify command to verify secretsManager JSON Key

fix #532

fujiwara
fujiwara requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@fujiwara fujiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m22r Thank you! Please confirm a review comment.

@m22r @fujiwara
Update verify.go
3e0e3fd 
Co-authored-by: FUJIWARA Shunichiro <fujiwara.shunichiro@gmail.com>
@m22r
Copy link
Contributor Author

m22r commented Mar 16, 2023

@fujiwara Thank you for your review comment. I had fixed in 3e0e3fd

@m22r m22r requested a review from fujiwara March 16, 2023 05:33
@fujiwara fujiwara merged commit 9db286e into kayac:v2 Mar 16, 2023
@fujiwara
Copy link
Collaborator

@m22r Thank you!

@m22r m22r deleted the verify_json_secrets branch March 16, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujiwara fujiwara fujiwara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecspresso verify cannot validate secret value when using JSON keys in AWS Secrets Manager
2 participants
@m22r @fujiwara