Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming visualizations plugin folder to kebab-case #26

Open
wants to merge 1 commit into
base: kebab-case
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Renaming visualizations plugin folder to kebab-case
Signed-off-by: Vacha Shah <vachshah@amazon.com>
  • Loading branch information
VachaShah committed Jun 3, 2021
commit e9d110d5a6144aa63cf62a17524c6dd61f9cef5d
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import {
} from '../services';
import { VisualizeEmbeddableFactoryDeps } from './visualize_embeddable_factory';
import { VISUALIZE_ENABLE_LABS_SETTING } from '../../common/constants';
import { SavedVisualizationsLoader } from '../saved_visualizations';
import { SavedVisualizationsLoader } from '../saved-visualizations';
import { AttributeService } from '../../../dashboard/public';
import { IndexPattern } from '../../../data/public';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ import { VisualizeEmbeddableFactoryDeps } from './visualize_embeddable_factory';
import { TriggerId } from '../../../ui_actions/public';
import { SavedObjectAttributes } from '../../../../core/types';
import { AttributeService } from '../../../dashboard/public';
import { SavedVisualizationsLoader } from '../saved_visualizations';
import { SavedVisualizationsLoader } from '../saved-visualizations';
import { VisSavedObject } from '../types';

const getKeys = <T extends {}>(o: T): Array<keyof T> => Object.keys(o) as Array<keyof T>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ import {
getSavedVisualizationsLoader,
} from '../services';
import { showNewVisModal } from '../wizard';
import { convertToSerializedVis } from '../saved_visualizations/_saved_vis';
import { convertToSerializedVis } from '../saved-visualizations/_saved_vis';
import { createVisEmbeddableFromObject } from './create_vis_embeddable_from_object';
import { StartServicesGetter } from '../../../opensearch_dashboards_utils/public';
import { VisualizationsStartDeps } from '../plugin';
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/visualizations/public/expressions/vis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import _ from 'lodash';
import { VisParams, PersistedState } from '../../../../plugins/visualizations/public';

import { getTypes } from '../services';
import { VisType } from '../vis_types';
import { VisType } from '../vis-types';

export interface ExprVisState {
title?: string;
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/visualizations/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ export function plugin(initializerContext: PluginInitializerContext) {

/** @public static code */
export { Vis } from './vis';
export { TypesService } from './vis_types/types_service';
export { TypesService } from './vis-types/types_service';
export { VISUALIZE_EMBEDDABLE_TYPE, VIS_EVENT_TO_TRIGGER } from './embeddable';
export { VisualizationContainer, VisualizationNoResults } from './components';
export { getSchemas as getVisSchemas } from './legacy/build_pipeline';

/** @public types */
export { VisualizationsSetup, VisualizationsStart };
export { VisTypeAlias, VisType, BaseVisTypeOptions, ReactVisTypeOptions } from './vis_types';
export { VisTypeAlias, VisType, BaseVisTypeOptions, ReactVisTypeOptions } from './vis-types';
export { VisParams, SerializedVis, SerializedVisData, VisData } from './vis';
export type VisualizeEmbeddableFactoryContract = PublicContract<VisualizeEmbeddableFactory>;
export type VisualizeEmbeddableContract = PublicContract<VisualizeEmbeddable>;
Expand All @@ -58,7 +58,7 @@ export type ExprVis = ExprVisClass;
export { SchemaConfig, BuildPipelineParams } from './legacy/build_pipeline';
// @ts-ignore
export { updateOldState } from './legacy/vis_update_state';
export { PersistedState } from './persisted_state';
export { PersistedState } from './persisted-state';
export {
VisualizationController,
SavedVisState,
Expand All @@ -67,5 +67,5 @@ export {
VisResponseValue,
} from './types';
export { ExprVisAPIEvents } from './expressions/vis';
export { VisualizationListItem } from './vis_types/vis_type_alias_registry';
export { VisualizationListItem } from './vis-types/vis_type_alias_registry';
export { VISUALIZE_ENABLE_LABS_SETTING } from '../common/constants';
10 changes: 5 additions & 5 deletions src/plugins/visualizations/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import {
ApplicationStart,
SavedObjectsClientContract,
} from '../../../core/public';
import { TypesService, TypesSetup, TypesStart } from './vis_types';
import { TypesService, TypesSetup, TypesStart } from './vis-types';
import {
setUISettings,
setTypes,
Expand Down Expand Up @@ -72,8 +72,8 @@ import { ExpressionsSetup, ExpressionsStart } from '../../expressions/public';
import { EmbeddableSetup, EmbeddableStart } from '../../embeddable/public';
import { visualization as visualizationFunction } from './expressions/visualization_function';
import { visualization as visualizationRenderer } from './expressions/visualization_renderer';
import { range as rangeExpressionFunction } from './expression_functions/range';
import { visDimension as visDimensionExpressionFunction } from './expression_functions/vis_dimension';
import { range as rangeExpressionFunction } from './expression-functions/range';
import { visDimension as visDimensionExpressionFunction } from './expression-functions/vis_dimension';
import { DataPublicPluginSetup, DataPublicPluginStart } from '../../../plugins/data/public';
import {
Setup as InspectorSetup,
Expand All @@ -84,14 +84,14 @@ import {
createStartServicesGetter,
StartServicesGetter,
} from '../../opensearch_dashboards_utils/public';
import { createSavedVisLoader, SavedVisualizationsLoader } from './saved_visualizations';
import { createSavedVisLoader, SavedVisualizationsLoader } from './saved-visualizations';
import { SerializedVis, Vis } from './vis';
import { showNewVisModal } from './wizard';
import { UiActionsStart } from '../../ui_actions/public';
import {
convertFromSerializedVis,
convertToSerializedVis,
} from './saved_visualizations/_saved_vis';
} from './saved-visualizations/_saved_vis';
import { createSavedSearchesLoader } from '../../discover/public';
import { DashboardStart } from '../../dashboard/public';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import { findListItems } from './find_list_items';
import { coreMock } from '../../../../core/public/mocks';
import { SavedObjectsClientContract } from '../../../../core/public';
import { VisTypeAlias } from '../vis_types';
import { VisTypeAlias } from '../vis-types';

describe('saved_visualizations', () => {
function testProps() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
import _ from 'lodash';
import { SavedObjectAttributes, SavedObjectsClientContract } from '../../../../core/public';
import { SavedObjectLoader } from '../../../../plugins/saved_objects/public';
import { VisTypeAlias } from '../vis_types';
import { VisualizationsAppExtension } from '../vis_types/vis_type_alias_registry';
import { VisTypeAlias } from '../vis-types';
import { VisualizationsAppExtension } from '../vis-types/vis_type_alias_registry';

/**
* Search for visualizations and convert them into a list display-friendly format.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
} from '../../../../plugins/saved_objects/public';
import { findListItems } from './find_list_items';
import { createSavedVisClass } from './_saved_vis';
import { TypesStart } from '../vis_types';
import { TypesStart } from '../vis-types';

export interface SavedObjectOpenSearchDashboardsServicesWithVisualizations
extends SavedObjectOpenSearchDashboardsServices {
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/visualizations/public/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import {
OverlayStart,
SavedObjectsStart,
} from '../../../core/public';
import { TypesStart } from './vis_types';
import { TypesStart } from './vis-types';
import { createGetterSetter } from '../../../plugins/opensearch_dashboards_utils/public';
import {
DataPublicPluginStart,
Expand All @@ -51,7 +51,7 @@ import {
import { UsageCollectionSetup } from '../../../plugins/usage_collection/public';
import { ExpressionsStart } from '../../../plugins/expressions/public';
import { UiActionsStart } from '../../../plugins/ui_actions/public';
import { SavedVisualizationsLoader } from './saved_visualizations';
import { SavedVisualizationsLoader } from './saved-visualizations';
import { SavedObjectLoader } from '../../saved_objects/public';
import { EmbeddableStart } from '../../embeddable/public';

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/visualizations/public/vis.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jest.mock('./services', () => {
}

// eslint-disable-next-line
const { BaseVisType } = require('./vis_types/base_vis_type');
const { BaseVisType } = require('./vis-types/base_vis_type');
// eslint-disable-next-line
const { SearchSource } = require('../../data/common/search/search_source');
// eslint-disable-next-line
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/visualizations/public/vis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
import { isFunction, defaults, cloneDeep } from 'lodash';
import { Assign } from '@osd/utility-types';
import { i18n } from '@osd/i18n';
import { PersistedState } from './persisted_state';
import { PersistedState } from './persisted-state';
import { getTypes, getAggs, getSearch, getSavedSearchLoader } from './services';
import { VisType } from './vis_types';
import { VisType } from './vis-types';
import {
IAggConfigs,
IndexPattern,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

import React from 'react';
import { mountWithIntl } from 'test_utils/enzyme_helpers';
import { TypesStart, VisType } from '../vis_types';
import { TypesStart, VisType } from '../vis-types';
import { NewVisModal } from './new_vis_modal';
import { ApplicationStart, SavedObjectsStart } from '../../../../core/public';
import { embeddablePluginMock } from '../../../embeddable/public/mocks';
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/visualizations/public/wizard/new_vis_modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ import { i18n } from '@osd/i18n';

import { METRIC_TYPE, UiStatsMetricType } from '@osd/analytics';
import { ApplicationStart, IUiSettingsClient, SavedObjectsStart } from '../../../../core/public';
import { SearchSelection } from './search_selection';
import { TypeSelection } from './type_selection';
import { TypesStart, VisType, VisTypeAlias } from '../vis_types';
import { SearchSelection } from './search-selection';
import { TypeSelection } from './type-selection';
import { TypesStart, VisType, VisTypeAlias } from '../vis-types';
import { UsageCollectionSetup } from '../../../../plugins/usage_collection/public';
import { EmbeddableStateTransfer } from '../../../embeddable/public';
import { VISUALIZE_ENABLE_LABS_SETTING } from '../../common/constants';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import React from 'react';
import { IUiSettingsClient, SavedObjectsStart } from '../../../../../core/public';

import { SavedObjectFinderUi } from '../../../../../plugins/saved_objects/public';
import { VisType } from '../../vis_types';
import { VisType } from '../../vis-types';

interface SearchSelectionProps {
onSearchSelected: (searchId: string, searchType: string) => void;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import { FormattedMessage } from '@osd/i18n/react';
import React, { Fragment } from 'react';
import { EuiText, EuiButton } from '@elastic/eui';
import { VisTypeAlias } from '../../vis_types';
import { VisTypeAlias } from '../../vis-types';

interface Props {
promotedTypes: VisTypeAlias[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ import {
} from '@elastic/eui';

import { memoizeLast } from '../../legacy/memoize';
import { VisTypeAlias } from '../../vis_types/vis_type_alias_registry';
import { VisTypeAlias } from '../../vis-types/vis_type_alias_registry';
import { NewVisHelp } from './new_vis_help';
import { VisHelpText } from './vis_help_text';
import { VisTypeIcon } from './vis_type_icon';
import { VisType, TypesStart } from '../../vis_types';
import { VisType, TypesStart } from '../../vis-types';

interface VisTypeListEntry {
type: VisType | VisTypeAlias;
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/visualizations/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ import {

import { VISUALIZE_ENABLE_LABS_SETTING } from '../common/constants';

import { visualizationSavedObjectType } from './saved_objects';
import { visualizationSavedObjectType } from './saved-objects';

import { VisualizationsPluginSetup, VisualizationsPluginStart } from './types';
import { registerVisualizationsCollector } from './usage_collector';
import { registerVisualizationsCollector } from './usage-collector';

export class VisualizationsPlugin
implements Plugin<VisualizationsPluginSetup, VisualizationsPluginStart> {
Expand Down