PseudoCacheMergeFragment: onNext now only adds the next 'contributor'… #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at a time instead of the entire adapter clear & reload.
|
heya thanks for this but the problem with this approach is that the previously added "stale" data remains in the list. if you spin up the example you'll notice both JW[0] and JW[800] in the list. we could be smart and only update the results but that's why i went nuclear and just wiped the whole list and re-added :) closing this for now. if you feel strongly that we should do this better, please feel free to reopen with changes to the PR, so stale date doesn't remain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CashMergeFragment only adds the next contributor at a time instead of clearing & updating entire adapter for each next contributor.