fix: Reverse length, alma comment

kauandotnet · Jul 26, 2022 · 55704fd · 55704fd
1 parent e097421
commit 55704fd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/pkg/indicator/alma.go b/pkg/indicator/alma.go
@@ -15,8 +15,8 @@ import (
 type ALMA struct {
 	types.SeriesBase
 	types.IntervalWindow         // required
-	Offset               float64 // required: recommend to be 5
-	Sigma                int     // required: recommend to be 0.5
+	Offset               float64 // required: recommend to be 0.5
+	Sigma                int     // required: recommend to be 5
 	weight               []float64
 	sum                  float64
 	input                []float64

diff --git a/pkg/types/indicator.go b/pkg/types/indicator.go
@@ -651,13 +651,10 @@ func Array(a Series, limit ...int) (result []float64) {
 //
 // notice that the return type is a Float64Slice, which implements the Series interface
 func Reverse(a Series, limit ...int) (result Float64Slice) {
-	l := -1
-	if len(limit) > 0 {
+	l := a.Length()
+	if len(limit) > 0 && l >= limit[0] {
 		l = limit[0]
 	}
-	if l > a.Length() {
-		l = a.Length()
-	}
 	result = make([]float64, l)
 	for i := 0; i < l; i++ {
 		result[l-i-1] = a.Index(i)