Fix app killing itself when opening deep links #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a deep link this plugin is loaded twice on the same process, so we cannot kill the app when destroying the first plugin. This line was first added by katzer#304 However the issue this was intended to solve was likely fixed by removing the launchMode singleInstance (already merged), as explained in here: katzer#261 (comment)
When opening a deep link this plugin is loaded twice on the same process, so we cannot kill the app when destroying the first plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a deep link this plugin is loaded twice on the same process, so we cannot kill the app when destroying the first plugin.
This line was first added by #304
However the issue this was intended to solve was likely fixed by removing the launchMode singleInstance (already merged), as explained in here: #261 (comment)