Replace ndk-glue with ndk-context #42
Conversation
src/java_interface/utils.rs
Outdated
| let vm = Arc::new(unsafe { JavaVM::from_raw(activity.vm())? }); | ||
| let activity = activity.activity(); | ||
| let vm = Arc::new(unsafe { JavaVM::from_raw(context.vm().cast())? }); | ||
| let activity = context.context() as jobject; |
There was a problem hiding this comment.
Perhaps rename activity to context everywhere for consistency? Otherwise, should AndroidContext have a method to Optionally test if - and downcast - the context back to an Activity JObject?
There was a problem hiding this comment.
Done. No, I believe ndk-context can keep the ambiguity in the API. It's the downstream libraries that can do checks to verify that the pointer is an activity or not.
There was a problem hiding this comment.
It would of course be an additional helper function, .context() continues to exist as it is. However, without dependency on jni it wouldn't be possible to implement it.
There was a problem hiding this comment.
I think the virtue of ndk-context is how small in scope it is. I don't feel we need to add helper functions. ndk-context will be used by low level crates anyway.
There was a problem hiding this comment.
Excactly, hence why we don't have and will probably never add the jni dependency.
Related issues: RustAudio/cpal#641 rust-mobile/ndk#211
Unfortunately I cannot test. I need help for this