Update jni #33
Merged
Update jni #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This borked bevy's cargo deny check because cpal depends on jni directly and via this crate so there were multiple versions
|
@katyo would it be possible to get a release containing this please? It's still causing the issue for If you don't think this is a semver compatible change, then I don't want to push for a major release just for this dependency - I'm unclear how much jni influences the public interface. Of potential note here is that |
|
@DJMcNab version 0.4.3 issued on crates.io! |
|
@DJMcNab Unfortunately I forget to update pre-generated bindings... I will issue 0.4.4 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bevy's cargo deny check failed because cpal depends on jni directly and via this crate.
This meant that there were multiple jni versions in our tree.
Please note that I haven't tested this, and haven't managed to build locally, so I'm going to see what CI says first - hopefully it will go through without issue.