Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jni 0.17 #24

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Update to jni 0.17 #24

merged 1 commit into from
Jan 14, 2021

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jan 12, 2021

This updates oboe to use jni version 0.17. This prevents jni being compiled twice when depending on the cpal crate, which depends on jni 0.17 and oboe 0.3.

I wasn't able to update it to the latest version 0.18 of jni due to the following error:

error[E0277]: `?` couldn't convert the error to `jni::errors::Error`
  --> oboe/src/java_interface/devices_info.rs:68:59
   |
68 |                 .ok_or_else(|| "Invalid device direction")?,
   |                                                           ^ the trait `From<&str>` is not implemented for `jni::errors::Error`
   |
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the following implementations were found:
             <jni::errors::Error as From<TryLockError<T>>>
   = note: required by `std::convert::From::from`

@bjorn3
Copy link
Contributor Author

bjorn3 commented Jan 12, 2021

CI failure seems unrelated.

Copy link
Owner

@katyo katyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katyo katyo merged commit f7b5ba1 into katyo:master Jan 14, 2021
@bjorn3 bjorn3 deleted the update_jni_0_17 branch January 14, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants